Remove respond_to? check for Thread#name= #8440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bundler now requires 3.3.1, we no longer need to do respond_to? check before setting thread name.
deivid-rodriguez
approved these changes
Jan 27, 2025
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Cool, thank you for the cleanup!
Contributor
Author
|
Thanks for the merge @deivid-rodriguez 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
This a housekeeping PR. Since bundler now requires 3.3.1, we no longer need to do respond_to? check before setting thread name.
What is your fix for the problem, implemented in this PR?
I was browsing the source code to learn about thread pool implementations and noticed an obsolete check based on the required Ruby version.
Make sure the following tasks are checked