Deprecate CurrentRuby#maglev? and other related maglev methods
#8452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
force-pushed
the
ec-deprecate-maglev
branch
2 times, most recently
from
5fb83de to
f92d2c9
Compare
deivid-rodriguez
approved these changes
Jan 31, 2025
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Looks great! I would've done it a bit differently, but I'm good if you prefer your way.
- Follow up to ruby#8430 (comment). The maglev platform was not supported by Bundler, so calling `gem "foo", platforms: ["maglev"]` would raise an error. The helpers added in the `CurrentRuby` class were used at a time when maglev was supported (as explained in 45ec86e). Support of maglev was most likely dropped at some point and the helpers in the `CurrentRuby` class were not deprecated/removed. We decided to deprecate them now.
Edouard-chin
force-pushed
the
ec-deprecate-maglev
branch
from
f92d2c9 to
66388ba
Compare
Contributor
Author
|
Thanks for reviewing ! |
deivid-rodriguez
changed the title
CurrentRuby#maglev? and other related maglev methods:CurrentRuby#maglev? and other related maglev methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Follow up to #8430 (comment).
The maglev platform was not supported by Bundler, so calling
gem "foo", platforms: ["maglev"]would raise an error.The helpers added in the
CurrentRubyclass were used at a time when maglev was supported (as explained in 45ec86e). Support of maglev was most likely dropped at some point and the helpers in theCurrentRubyclass were not deprecated/removed.We decided to deprecate them now.
Make sure the following tasks are checked