Fix bundle console printing bug report template on NameError during require
#8804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
bundler-console-other-errors
branch
3 times, most recently
from
d0f0edb to
3a0a165
Compare
deivid-rodriguez
approved these changes
Jul 1, 2025
…ng require Followup to ruby#8436 It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code. I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
deivid-rodriguez
force-pushed
the
bundler-console-other-errors
branch
from
3a0a165 to
1c910e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Followup to #8436
It fixed showing the template when requiring a non-existant file but user code can do much more than just trying to require other code.
I encountered this particular case because of load order issues, where a library wasn't able to properly require itself when loaded before some other library.
What is your fix for the problem, implemented in this PR?
Rescue the much more generic
StandardErrorinstead. I believe this is fine, since no bundler/rubygems related code that runs inbetween that could be accidentally catched by this. There was no issue when using it plainly with rails butbundle consolemade issues.Make sure the following tasks are checked