Add Ruby 3.4 to CI, fix warning for 3.4 and error for 3.5/HEAD #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jan 21, 2025
xmlrpc.gemspec
Outdated
| spec.require_paths = ["lib"] | ||
| spec.required_ruby_version = ">= 2.3" | ||
|
|
||
| spec.add_dependency "logger" |
Member
There was a problem hiding this comment.
Why do we need this?
xmlrpc doesn't use Logger explicitly.
Member
Author
There was a problem hiding this comment.
My bad, it's a development dependency, so I moved it to the correct location.
Member
There was a problem hiding this comment.
It seems that our tests also don't use Logger explicitly.
Could you share warnings you got?
Member
Author
There was a problem hiding this comment.
$ ruby -v && bundle exec rake test
ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [x86_64-linux]
test/test_webrick_server.rb:9: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.
[...]
But I tried to run the test suite with that line removed and everything works, so I guess it's easier to just remove that require from the tests.
This gem is no longer a default gem in Ruby 3.5, but we don't use it.
Member
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.