Add Nokogiri XML parser #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is similar to the LibXML parser, but uses the Nokogiri SAX parser under the hood. This library is already used in a lot of web projects and is easier to install in Windows than LibXML. There is no direct dependency on the nokogiri gem, if the gem is not available the code will only error in case it is used.
The old text was outdated, Expat parser has not been available for years.
It does pass the tests on the regular windows images, but mingw and mswin fail in the compilation step of the nokogiri gem. This can probably be fixed by installing the right development libraries, but I could not find out how.
Member
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is similar to the LibXML parser, but uses the Nokogiri SAX parser under the hood. This library is already used in a lot of web projects and is easier to install in Windows than LibXML.
There is no direct dependency on the nokogiri gem, if the gem is not available the code will only error in case it is used.
Unfortunately, I could not find a way to enable the gem in the CI for the Windows tasks. It passes on the regular Windows runners, but fails on mingw/mswin, and I could not find a way to separate those two. If someone knows how to fix that, or how to install/compile Nokogiri on the latter two platforms, please go ahead and fix it.
This has been suggested/requested in https://bugs.ruby-lang.org/issues/9379, all the way back in 2014.