Skip to content

fa- => bi- icon transitions still remained #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amatsuda merged 2 commits into from
Dec 24, 2025
+4 −4
Merged

fa- => bi- icon transitions still remained #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05b98ee
Remaining fa- => bi- icon transitions
amatsuda Dec 24, 2025
b7ecb9a
Unused lvar
amatsuda Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/decorators/staff/program_session_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ def state_label(large: false, state: nil)

def confirmation_notes_link
return '' unless object.confirmation_notes?
id = h.dom_id(object, 'notes')

h.link_to h.event_staff_program_session_path(object.event, object) do
h.content_tag(:i, '', class: 'fa fa-file')
h.content_tag(:i, '', class: 'bi bi-file-text')
end
end

Expand Down
2 changes: 1 addition & 1 deletion app/helpers/website_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def legend_with_docs(title)

def link_to_docs(anchor)
link_to(DOCS_PAGE + "##{anchor}", target: "_blank") do
content_tag("i", nil, class: "fa fa-fw fa-question-circle")
content_tag('i', nil, class: 'bi bi-question-circle')
end
end
end
2 changes: 1 addition & 1 deletion config/initializers/simple_form/popover_icon_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def icon
return if popover_content.blank?
template.capture do
template.content_tag(:a, class:'btn btn-icon hint-btn popover-trigger', data: { target: popover_selector }) do
template.content_tag(:i, '', class: 'fa fa-fw fa-question-circle')
template.content_tag(:i, '', class: 'bi bi-question-circle')
end
end.html_safe
end
Expand Down