6313 - Case Court Reports Index Spec Overhaul #6581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

compwron merged 43 commits into rubyforgood:main from AudTheCodeWitch:acook/6313/update-case-court-reports-index-spec

Nov 5, 2025

Contributor

AudTheCodeWitch commented Oct 29, 2025

What github issue is this PR for, if any?

Resolves #6313

What changed, and why?

This PR is a comprehensive refactor of the test suite for the Case Court Reports feature. The original spec file was refactored to be faster, more reliable, and easier to maintain.

Key Changes:

Refactored spec/system/case_court_reports/index_spec.rb:
- Added "Happy Path" Test: Added a full, end-to-end system test that selects a case, generates a report, waits for the background job, and confirms the file is successfully attached in the database.
- Added comprehensive tests for case visibility in the autocomplete dropdown for all three user roles (Volunteer, Supervisor, and Admin).
- Consolidated Supervisor and Admin autocomplete tests into a shared_example (a user with organization-level case visibility in autocomplete) to reduce duplication.
- Broke up large, multi-assertion tests into smaller, focused tests (e.g., for default dates, error states, and transition labels). Note: I didn't observe any increase in how long it took to run the tests
- Resolved all outstanding RuboCop warnings by removing unused let statements and safely disabling warnings for complex but necessary test setup.
Improved Test Organization:
- Moved tests verifying the download link on the case details page from index_spec.rb to spec/system/casa_cases/show_spec.rb.
- Added new request specs for date filtering to spec/requests/case_court_reports_spec.rb.
- Extracted helper methods into spec/support/case_court_report_helpers.rb.

This PR completes all outstanding test work for this feature.

How is this tested? 💖💪

RSpec system specs in spec/system/case_court_reports/index_spec.rb.
RSpec system specs in spec/system/casa_cases/show_spec.rb.
RSpec request specs in spec/requests/case_court_reports_spec.rb.
All specs passing (ran 100+ times with no flakes!)

Feelings gif

AudTheCodeWitch added 30 commits

October 29, 2025 12:35


          Test: update index specs to use aggregate_failures for improved error…

70ada8a

… reporting

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: improve case selection in index specs with visibility checks an…

e7cd479

…d click actions

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove unnecessary setup steps in index specs for court reports

8068c9f

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: replace build with create for supervisor and casa_admin in case…

da4d8cc

… details report access specs

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: update supervisor report download spec to use create and add re…

7319e8c

…port generation simulation

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: update supervisor report download spec to use create and add re…

f7e6f63

…port generation simulation

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor index specs for court reports to reduce redundancy and…

d592fb6

… improve timeout settings

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          TODO: left notes for when I return next week

f6b3bdc

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: replace find with detect for improved readability in index specs

1e0730d

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: improve context description in court report download modal spec…

f2c6a46

… for clarity

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: update visibility expectations in case court reports index spec…

… for clarity

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: ensure casa_case is reloaded before checking court report statu…

7ec8176

…s in index spec

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: add date filtering for case court reports request spec

f6d58ce

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove TODO comment (not needed)

6ab5543

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: add helper methods for case court reports system specs

83615e9

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: add autocomplete case visibility tests for volunteers, supervis…

984518f

…ors, and admins

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Lint

545a74d

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: enhance case court report helpers

627025a

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: Optimize factory usage in court reports spec

e6905bd

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor court reports index spec to use shared context for use…

500572a

…r roles

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor case selection visibility specs to use shared examples…

f55c78d

… for user roles

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor court reports index spec to use shared context for use…

ddbc818

…r roles

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove unused variables in court reports index spec

8331e16

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: enhance case selection visibility in court reports index spec

f790263

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove outdated comment in court reports index spec

74fd8a8

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Lint

b384b31

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: break "God Test" into smaller, individual tests.

9b5c41b

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: reduce sleep duration in court reports attachment check

921fd4b

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Add sample_report.docx fixture

40c08c6

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: move casa_case_path tests to the proper file (show_spec.rb)

730e675

Signed-off-by: Audrea Cook <audrea@codewitch.dev>

AudTheCodeWitch added 13 commits

October 29, 2025 13:25


          Test: refactor date handling in case_court_reports/index spec

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: move transition age case variables inside the test block

88ccc4e

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove unnecessary blank line in show_spec.rb

f86a8c2

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: disable ghost rubocop warning

f803b32

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: remove unused case variables in index_spec.rb

290dc47

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: Lint

7dfcbbc

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: disable RSpec/MultipleMemoizedHelpers cop for case selection vi…

9f1b99d

…sibility specs

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: adjust RSpec/MultipleMemoizedHelpers cop placement in index_spe…

649b331

…c.rb

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor case selection specs for clarity and organization

d4243b4

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: update transition status label specs to disable RSpec/ExampleLe…

28b3d70

…ngth cop

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: disable RSpec/LetSetup cop for other_org_case in index_spec.rb

dc80429

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: refactor let declarations in case_court_reports/index specs for…

f298035

… consistency

Signed-off-by: Audrea Cook <audrea@codewitch.dev>


          Test: add spec for report generation and attachment in case court rep…

1f0caf3

…orts

Signed-off-by: Audrea Cook <audrea@codewitch.dev>

AudTheCodeWitch requested review from FireLemons, compwron and elasticspoon as code owners

October 29, 2025 21:12

github-actions bot added ruby Tests! 🎉💖👏 labels

AudTheCodeWitch changed the title ~~Acook/6313/update case court reports index spec~~ 6313 - Case Court Reports Index Spec Overhaul

Contributor Author

AudTheCodeWitch commented Nov 2, 2025

@compwron, any chance you could get your eyes on this pr and/or add the hacktoberfest-accepted label this weekend? Happy to address any comments/code review later... I was just hoping to wrap up this year's Hacktoberfest. 😊

Collaborator

compwron commented Nov 5, 2025

I'm sorry I missed this for hacktoberfest!! :( It looks great :)

compwron approved these changes

View reviewed changes

compwron merged commit 0eb8383 into rubyforgood:main

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Tests! 🎉💖👏