6600 volunteer emailsave #6639
Open
6600 volunteer emailsave #6639
+31
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Budmin
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6600
What changed, and why?
Volunteers aren't sent a confirmation email before their email is updated, it just updates now.
This was changed because it's not needed for CASA's use case.
I also changed the "Submit" button to an "Update" button.
This wasn't in the Issue, I just thought it was more intuitive for users who don't realize they're submitting a form.
How is this tested? (please write rspec and jest tests!) 💖💪
Tests that checked for confirmation emails when updating Volunteer emails were either modified or replaced to check for the record and UI updating as expected.
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
(No email in between now...)
Submit -> Update button change
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
