Skip to content

Fix race conditions in system specs Fixes #6693 #6724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexWheeler wants to merge 4 commits into from
+1,593 −1,516
Closed

Fix race conditions in system specs Fixes #6693 #6724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
503e1c0
Fix race conditions in system specs
AlexWheeler Feb 16, 2026
3729164
Fix test suite pollution and flaky system specs
AlexWheeler Feb 16, 2026
f583627
Fix additional time leakage in specs
AlexWheeler Feb 17, 2026
7bbef58
Fix time leakage in system and request specs
AlexWheeler Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 58 additions & 58 deletions spec/callbacks/case_contact_metadata_callback_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "rails_helper"
require 'rails_helper'

RSpec.describe CaseContactMetadataCallback do
let(:past) { Date.new(2020, 1, 1).in_time_zone }
Expand All @@ -14,127 +14,127 @@
# with metadata surrounding cases that are not processed in the correct order.
# A user would not be able to replicate this behavior.
#
describe "after_commit" do
it "sets started metadata when case contact is created" do
describe 'after_commit' do
it 'sets started metadata when case contact is created' do
cc = create(:case_contact)

expect(cc.metadata.dig("status", "active")).to eq(parsed_present)
expect(cc.metadata.dig('status', 'active')).to eq(parsed_present)
end

context "case contact is in started status" do
context 'case contact is in started status' do
let(:case_contact) { create(:case_contact, :started, created_at: past) }

context "updates to started status" do
before { case_contact.update(status: "started") }
context 'updates to started status' do
before { case_contact.update(status: 'started') }

it "does not update the metadata" do
expect(case_contact.metadata.dig("status", "started")).to eq(parsed_past)
it 'does not update the metadata' do
expect(case_contact.metadata.dig('status', 'started')).to eq(parsed_past)
end
end

context "updates to details status" do
before { case_contact.update(status: "details") }
context 'updates to details status' do
before { case_contact.update(status: 'details') }

it { expect(case_contact.metadata.dig("status", "details")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'details')).to eq(parsed_present) }
end

context "updates to notes status" do
before { case_contact.update(status: "notes") }
context 'updates to notes status' do
before { case_contact.update(status: 'notes') }

it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'notes')).to eq(parsed_present) }
end

context "updates to expenses status" do
before { case_contact.update(status: "expenses") }
context 'updates to expenses status' do
before { case_contact.update(status: 'expenses') }

it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'expenses')).to eq(parsed_present) }
end

context "updates to active status" do
before { case_contact.update(status: "active") }
context 'updates to active status' do
before { case_contact.update(status: 'active') }

it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'active')).to eq(parsed_present) }
end
end

context "case contact is in details status" do
context 'case contact is in details status' do
let(:case_contact) { create(:case_contact, :details, created_at: past) }

context "updates to details status" do
before { case_contact.update(status: "details") }
context 'updates to details status' do
before { case_contact.update(status: 'details') }

it "does not update the metadata" do
expect(case_contact.metadata.dig("status", "details")).to eq(parsed_past)
it 'does not update the metadata' do
expect(case_contact.metadata.dig('status', 'details')).to eq(parsed_past)
end
end

context "updates to notes status" do
before { case_contact.update(status: "notes") }
context 'updates to notes status' do
before { case_contact.update(status: 'notes') }

it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'notes')).to eq(parsed_present) }
end

context "updates to expenses status" do
before { case_contact.update(status: "expenses") }
context 'updates to expenses status' do
before { case_contact.update(status: 'expenses') }

it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'expenses')).to eq(parsed_present) }
end

context "updates to active status" do
before { case_contact.update(status: "active") }
context 'updates to active status' do
before { case_contact.update(status: 'active') }

it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'active')).to eq(parsed_present) }
end
end

context "case contact is in notes status" do
context 'case contact is in notes status' do
let(:case_contact) { create(:case_contact, :notes, created_at: past) }

context "updates to notes status" do
before { case_contact.update(status: "notes") }
context 'updates to notes status' do
before { case_contact.update(status: 'notes') }

it { expect(case_contact.metadata.dig("status", "notes")).to eq(parsed_past) }
it { expect(case_contact.metadata.dig('status', 'notes')).to eq(parsed_past) }
end

context "updates to expenses status" do
before { case_contact.update(status: "expenses") }
context 'updates to expenses status' do
before { case_contact.update(status: 'expenses') }

it { expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'expenses')).to eq(parsed_present) }
end

context "updates to active status" do
before { case_contact.update(status: "active") }
context 'updates to active status' do
before { case_contact.update(status: 'active') }

it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'active')).to eq(parsed_present) }
end
end

context "case contact is in expenses status" do
context 'case contact is in expenses status' do
let!(:case_contact) { create(:case_contact, :expenses, created_at: past) }

context "updates to expenses status" do
before { case_contact.update(status: "expenses") }
context 'updates to expenses status' do
before { case_contact.update(status: 'expenses') }

it "does not update the metadata" do
expect(case_contact.metadata.dig("status", "expenses")).to eq(parsed_past)
it 'does not update the metadata' do
expect(case_contact.metadata.dig('status', 'expenses')).to eq(parsed_past)
end
end

context "updates to active status" do
before { case_contact.update(status: "active") }
context 'updates to active status' do
before { case_contact.update(status: 'active') }

it { expect(case_contact.metadata.dig("status", "active")).to eq(parsed_present) }
it { expect(case_contact.metadata.dig('status', 'active')).to eq(parsed_present) }
end
end

context "case contact is in active status" do
context 'case contact is in active status' do
let(:case_contact) { create(:case_contact, created_at: past) }

context "updates to active status" do
before { case_contact.update(status: "active") }
context 'updates to active status' do
before { case_contact.update(status: 'active') }

it "does not update the metadata" do
expect(case_contact.metadata.dig("status", "active")).to eq(parsed_past)
it 'does not update the metadata' do
expect(case_contact.metadata.dig('status', 'active')).to eq(parsed_past)
end
end
end
Expand Down
Loading