Resolves #5224: Banks can see partners's active children using items when deactivating

app/controllers/items_controller.rb

@@ -91,6 +91,14 @@ def update
 
   def deactivate
     item = current_organization.items.find(params[:id])
+
+    partners = Partner
+      .joins(families: {children: :requested_items})
+      .where(organization_id: current_organization.id)
+      .where(children: {active: true})
+      .where(items: {id: item.id})
+      .distinct
+
     begin
       item.deactivate!
     rescue => e
@@ -99,6 +107,11 @@ def deactivate
       return
     end
 
+    if partners.any?
+      flash[:alert] = "The following partners have active children with this item: " +
+        partners.map(&:name).map(&:downcase).sort.join(", ")
+    end
+
     flash[:notice] = "#{item.name} has been deactivated."
     redirect_to items_path
   end

app/models/item.rb

@@ -52,6 +52,7 @@ class Item < ApplicationRecord
   has_many :donations, through: :line_items, source: :itemizable, source_type: "::Donation"
   has_many :distributions, through: :line_items, source: :itemizable, source_type: "::Distribution"
   has_many :request_units, class_name: "ItemUnit", dependent: :destroy
+  has_and_belongs_to_many :children, class_name: "Partners::Child"
 
   scope :active, -> { where(active: true) }
 

spec/controllers/items_controller_spec.rb

@@ -219,6 +219,24 @@
         expect(response).to have_notice
       end
     end
+
+    describe "PATCH #deactivate" do
+      let(:item) { create(:item, organization: organization) }
+      let!(:partner) { create(:partner, organization: organization, name: "Helping Hands") }
+      let!(:family) { create(:partners_family, partner: partner) }
+      let!(:child) { create(:partners_child, family: family, active: true) }
+
+      before do
+        child.requested_items << item
+      end
+
+      it "sets a flash alert listing partners with active children for this item" do
+        patch :deactivate, params: { id: item.id }
+
+        expect(response).to redirect_to(items_path)
+        expect(flash[:alert]).to include("helping hands") # downcased in controller
+      end
+    end
   end
 
   context "While not signed in" do