add hidden RPC getorphantxs
#435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xB10C
commented
Dec 22, 2025
This was referenced Dec 22, 2025
Collaborator
jamillambert
left a comment
jamillambert
left a comment
There was a problem hiding this comment.
Most of it looks good. A few specific comments below.
0xB10C
force-pushed
the
2025-12-add-hidden-getorphantxs
branch
from
12204f8 to
ca15500
Compare
Contributor
Author
|
Addresses review. Thanks! |
Collaborator
|
Almost, for the client macros I meant that the list of macros in the hidden section for both v29 and v30 should be in alphabetical order like the other sections. |
0xB10C
force-pushed
the
2025-12-add-hidden-getorphantxs
branch
from
ca15500 to
04006e5
Compare
Contributor
Author
|
I see. Ignoring the |
0xB10C
dismissed
jamillambert’s stale review
The merge-base changed after approval.
Implement the RPC in v22 hidden module, add the client macro, model and test. Redefine the client macro in v27 where there is an added required argument. Add all the reexports up to v30.
0xB10C
force-pushed
the
2025-12-add-hidden-getorphantxs
branch
from
04006e5 to
a501481
Compare
Contributor
Author
|
No changes, just rebased. Will rebase again after #433. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the hidden
getorphantxsRPC in the last commit. Depends on #432 and #433. Part of #333.Since the
expiryandentryfields were dropped for v30 (this is an experimental RPC after all), there is ainto.rsimplementation for both v29 and v30.