Restore lock file on failure #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
First jujutsu-based patch, 🤞 |
tcharding
approved these changes
Jan 5, 2026
tcharding
reviewed
Jan 5, 2026
cargo-rbmt/src/lock.rs
Outdated
Comment on lines
23
to
24
| backup_path: std::path::PathBuf, | ||
| restore_path: std::path::PathBuf, |
Collaborator
Author
There was a problem hiding this comment.
No good reason, let me update that.
nyonson
force-pushed
the
restore-lock-file
branch
from
0dea2fd to
9749597
Compare
Collaborator
Author
|
9749597: add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for the bug found by @apoelstra in #60 (comment). I thought the recommended drop guard pattern turned out pretty slick, if a little verbose.