Configurable API features #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyonson
force-pushed
the
configurable-api-features
branch
2 times, most recently
from
aa5ff12 to
247d431
Compare
Upgraded public-api crate from v0.47 to v0.50.2 to support more recent nightly toolchain versions. The public-api versions only support a window of nightly versions. The new version of public-api uses edition 2024 which requires rust 1.85+ so the MSRV of cargo-rbmt was raised as well.
nyonson
force-pushed
the
configurable-api-features
branch
from
d37f782 to
c475f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the
apicommand more robust, been able to use it in therust-psbtproject as I explore different ways to break an exported API and see if this detects it. We might just have to drop these custom checks with cargo-semver-checks as discussed in #58, because this is quite the rabbit hole, but figure I'd give it the old college try and learn along the way.I think this new
rbmt.tomlconfig for the api command will be helpful no matter what. It also lets a user opt-in to the semver checking, they have to set abaselinein the package config.