Support opening files by long file name #217
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because now it can delete directories and files.
) Methods on File and Directory now point you to the underlying VolumeManager method. ) VolumeManager methods have additional documentation.
The if block diverged, so the else block can be outdented.
Opening existing directories can be added later. Notably this does not require holding the entire LFN on the stack at once - we match the UTF-8 string slice we're given against the USC-2 words we pull off the disk, in reverse order. The shell example now lets you `cat` and `hexdump` files with long names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API which lets you open files by their long file name.
Does not (currently) let you open directories in this manner, nor does it let you create files with a long file name.
Builds on #216