attempt to use pkg-config to get include path for dependencies if not provided in env#525
Open
MagicalTux wants to merge 1 commit intorust-lang:masterfrom
Open
attempt to use pkg-config to get include path for dependencies if not provided in env#525MagicalTux wants to merge 1 commit intorust-lang:masterfrom
MagicalTux wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
I don't think this PR should be merged as is; please see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to alexcrichton/ssh2-rs#170 and solves issue in rust-lang/rust#69552
If dependencies include paths are not provided in environment (
DEP_SSH2_INCLUDE,DEP_OPENSSL_INCLUDEandDEP_Z_INCLUDE) then the script attempts to usepkg_configto find system-provided versions in order to buildlibgit2.