Skip to content

Conversation

@notriddle
Copy link
Contributor

These bugs cause a crash and a perf problem with aliases, caused by loading the search index when it's not expected.

cc @weihanglo

r? @GuillaumeGomez

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 6, 2025
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 6, 2025

📌 Commit 6fb8d9f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 6, 2025
…meGomez

rustdoc: fix bugs with search aliases and merging

These bugs cause a crash and a perf problem with aliases, caused by loading the search index when it's not expected.

cc `@weihanglo`

r? `@GuillaumeGomez`
@weihanglo
Copy link
Member

Tested and this PR eliminates the ICE I spotted in rust-lang/cargo#16309 (comment). Thanks!

bors added a commit that referenced this pull request Dec 6, 2025
Rollup of 5 pull requests

Successful merges:

 - #149659 (Look for typos when reporting an unknown nightly feature)
 - #149699 (Implement `Vec::from_fn`)
 - #149700 (rustdoc: fix bugs with search aliases and merging)
 - #149713 (Update windows-gnullvm platform support doc)
 - #149716 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants