-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Move ambient gdb discovery from compiletest to bootstrap #149710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zalathar
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
Zalathar:ambient-gdb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Member
Author
|
@bors try jobs=arm-android,x86_64-mingw-1,test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 6, 2025
Move ambient gdb discovery from compiletest to bootstrap try-job: arm-android try-job: x86_64-mingw-1 try-job: test-various
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
Member
Author
|
@bors try jobs=arm-android,x86_64-mingw-1,test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 6, 2025
Move ambient gdb discovery from compiletest to bootstrap try-job: arm-android try-job: x86_64-mingw-1 try-job: test-various
|
💔 Test for 8f3e014 failed: CI. Failed jobs:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code takes the compiletest code for discovering an “ambient”
gdbin the user's path, and moves it to bootstrap.One of the eventual goals is to allow compiletest to assume that if it has been asked to run the debuginfo-gdb suite, then it must have been passed an explicit
--gdb, though we aren't quite there yet.r? jieyouxu