Rollup of 4 pull requests #149729

matthiaskrgr · 2025-12-07T07:26:52Z

Successful merges:

Add warn-by-default lint for visibility on const _ declarations #147136 (Add warn-by-default lint for visibility on const _ declarations)
Tidying up tests/ui/issues tests [1/N] #149498 (Tidying up tests/ui/issues tests [1/N])
rustc book: fix *-pc-windows-msvc link label in sidebar #149721 (rustc book: fix *-pc-windows-msvc link label in sidebar)
Fix off-by-one staging output when testing the library #149724 (Fix off-by-one staging output when testing the library)

r? @ghost
@rustbot modify labels: rollup

As far as I know, `*-unknown-windows-msvc` is not a thing. At least if I search for "unknown-windows-msvc" in the entire [rust-lang](https://github.com/rust-lang) organization (https://github.com/search?q=org%3Arust-lang+%22unknown-windows-msvc%22++&type=code&state=open), it gives only this occurrence and 3 other occurrences in https://github.com/rust-lang/lld, which was archived in 2019. I believe `*-pc-windows-msvc` is the correct replacement because that is the name of the page the link points to: https://github.com/rust-lang/rust/blob/ba86c0460b0233319e01fd789a42a7276eade805/src/doc/rustc/src/platform-support/windows-msvc.md?plain=1#L1

Add a warn-by-default `unused_visibility` lint for visibility qualifiers on `const _` declarations - e.g. `pub const _: () = ();`. These have no effect.

merged tests/ui/issues/issue-2951.rs with tests/ui/type/type-parameter-names.rs Merged tests/ui/for-loop-while/break-continue-in-loop-while-contiditoin-1.rs with tests/ui/for-loop-while/break-continue-in-loop-while-contiditoin-2.rs Removed tests/ui/issues/issue-2383.rs duplicated of library\alloc\src\collections\vec_deque\tests.rs Removed tests/ui/issues/issue-20714.rs duplicated of tests/ui/empty/empty-struct-unit-expr.rs Added comment to tests/ui/match/match-option-result-mismatch.rs, tests/ui/numeric/ref-int.rs, tests/ui/box/self-assignment.rs

…, r=jdonszelmann Add warn-by-default lint for visibility on `const _` declarations Add a warn-by-default `unused_visibilities` lint for visibility qualifiers on `const _` declarations—e.g. `pub const _: () = ();`. Such qualifiers have no effect. A [Sourcegraph search](https://sourcegraph.com/search?q=context:global+lang:Rust+pub%5Cs*%28%5C%28.*%5C%29%29%3F%5Cs*const%5Cs%2B_%5Cs*:&patternType=regexp&case=yes&sm=0) suggests that this pattern is relatively rare, and mostly found in tests (with only 3 exceptions). So perhaps this could become an FCW/hard error in the future. `@rustbot` label T-lang A-lints A-visibility -T-clippy

Tidying up `tests/ui/issues` tests [1/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of rust-lang#133895

…nk-label-fix, r=ChrisDenton rustc book: fix `*-pc-windows-msvc` link label in sidebar As far as I know, `*-unknown-windows-msvc` is not a thing. At least if I search for "unknown-windows-msvc" in the entire [rust-lang](https://github.com/rust-lang) organization (https://github.com/search?q=org%3Arust-lang+%22unknown-windows-msvc%22++&type=code&state=open), it gives only this occurrence and 3 other occurrences in https://github.com/rust-lang/lld, which was archived in 2019. I believe `*-pc-windows-msvc` is the correct replacement because that is the name of the page the link points to: https://github.com/rust-lang/rust/blob/ba86c0460b0233319e01fd789a42a7276eade805/src/doc/rustc/src/platform-support/windows-msvc.md?plain=1#L1

…ouxu Fix off-by-one staging output when testing the library It seems generally useful to store the `Mode` in `Cargo`, I remember thinking a few times that it would be useful in other places. Fixes: rust-lang#149558 r? `@jieyouxu`

matthiaskrgr · 2025-12-07T07:27:45Z

@bors r+ rollup=never p=5

bors · 2025-12-07T07:27:47Z

📌 Commit 1eef811 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-12-07T10:32:38Z

⌛ Testing commit 1eef811 with merge aa30176...

bors · 2025-12-07T13:42:49Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing aa30176 to main...

rust-timer · 2025-12-07T13:44:00Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147136	Add warn-by-default lint for visibility on `const _` declar…	`3fbf8629fc7b456d94eb854336fa411bdbd94f91` (link)
#149498	Tidying up `tests/ui/issues` tests [1/N]	`3f8c946f7c3ba9c4c3bd3b3f066859b5417f2da2` (link)
#149721	rustc book: fix `*-pc-windows-msvc` link label in sidebar	`93ee65783ebd2c6e13efb3b68f0e5efa4abade22` (link)
#149724	Fix off-by-one staging output when testing the library	`a478271e69f64fae9fbef97f5f83cd6361740832` (link)

previous master: 1c5a0cfc13

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-12-07T13:45:48Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1c5a0cf (parent) -> aa30176 (this PR)

Test differences

Show 612 test diffs

Stage 0

lints::verify_lint_unused_visibilities_125: [missing] -> pass (J1)
transmute::verify_lint_undefined_transmute_125: pass -> [missing] (J1)
transmute::verify_lint_undefined_transmute_126: [missing] -> pass (J1)

Stage 1

lints::verify_lint_unused_visibilities_125: [missing] -> pass (J0)
transmute::verify_lint_undefined_transmute_125: pass -> [missing] (J0)
transmute::verify_lint_undefined_transmute_126: [missing] -> pass (J0)
[ui] tests/ui/box/self-assignment.rs: [missing] -> pass (J1)
[ui] tests/ui/for-loop-while/break-continue-in-loop-while-condition.rs: [missing] -> pass (J1)
[ui] tests/ui/issues/issue-20714.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-2383.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-2951.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-3091.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-3290.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-3680.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-37576.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-50802.rs: pass -> [missing] (J1)
[ui] tests/ui/lint/unused-visibilities.rs: [missing] -> pass (J1)
[ui] tests/ui/match/match-option-result-mismatch.rs: [missing] -> pass (J1)
[ui] tests/ui/numeric/ref-int.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/box/self-assignment.rs: [missing] -> pass (J2)
[ui] tests/ui/for-loop-while/break-continue-in-loop-while-condition.rs: [missing] -> pass (J2)
[ui] tests/ui/issues/issue-20714.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-2383.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-2951.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-3091.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-3290.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-3680.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-37576.rs: pass -> [missing] (J2)
[ui] tests/ui/issues/issue-50802.rs: pass -> [missing] (J2)
[ui] tests/ui/lint/unused-visibilities.rs: [missing] -> pass (J2)
[ui] tests/ui/match/match-option-result-mismatch.rs: [missing] -> pass (J2)
[ui] tests/ui/numeric/ref-int.rs: [missing] -> pass (J2)

Additionally, 580 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard aa301763000fd65db235b2d6e4c04da99abf8cd8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1566.1s -> 1967.6s (+25.6%)
x86_64-rust-for-linux: 2544.1s -> 3051.4s (+19.9%)
x86_64-gnu-gcc: 3027.8s -> 3528.4s (+16.5%)
aarch64-apple: 7907.0s -> 9207.9s (+16.5%)
aarch64-gnu-debug: 3954.1s -> 4534.6s (+14.7%)
x86_64-gnu-llvm-21-1: 3161.6s -> 3579.7s (+13.2%)
x86_64-gnu-llvm-20: 2478.1s -> 2785.2s (+12.4%)
pr-check-2: 2288.4s -> 2560.3s (+11.9%)
arm-android: 5657.3s -> 6324.6s (+11.8%)
x86_64-gnu-llvm-20-1: 3134.5s -> 3498.3s (+11.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-07T15:05:07Z

Finished benchmarking commit (aa30176): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.6%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Cycles

Results (primary 2.4%, secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.408s -> 472.025s (0.34%)
Artifact size: 388.91 MiB -> 388.84 MiB (-0.02%)

Kobzol · 2025-12-08T11:53:46Z

@rust-timer build 3f8c946

(don't mind this, just doing a test for rustc-perf)

rust-timer · 2025-12-08T12:35:36Z

Finished benchmarking commit (3f8c946): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.408s -> 473.082s (0.57%)
Artifact size: 388.91 MiB -> 388.91 MiB (0.00%)

reddevilmidzy and others added 13 commits December 1, 2025 18:55

moved tests

18d0c37

Add warn-by-default lint for visibility on const _ declarations

234df83

Add a warn-by-default `unused_visibility` lint for visibility qualifiers on `const _` declarations - e.g. `pub const _: () = ();`. These have no effect.

Elaborate lint explanation

4cc2f95

Don't warn when underscore is passed to macro

6b5da2f

Add note to lint message

9e72009

Expand lint note

43fa060

Fix off-by-one staging output when testing the library

7fdf066

Rollup merge of rust-lang#149498 - reddevilmidzy:t8, r=fee1-dead

1f458c6

Tidying up `tests/ui/issues` tests [1/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of rust-lang#133895

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 7, 2025

bors merged commit aa30176 into rust-lang:main Dec 7, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 7, 2025

bors mentioned this pull request Dec 7, 2025

Port doc attributes to new attribute API #149645

Open

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #149729

Rollup of 4 pull requests #149729

matthiaskrgr commented Dec 7, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 7, 2025

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Dec 7, 2025

Uh oh!

Kobzol commented Dec 8, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Rollup of 4 pull requests #149729

Rollup of 4 pull requests #149729

Conversation

matthiaskrgr commented Dec 7, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

bors commented Dec 7, 2025

Uh oh!

Uh oh!

rust-timer commented Dec 7, 2025

Uh oh!

github-actions bot commented Dec 7, 2025

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Dec 7, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Kobzol commented Dec 8, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Dec 8, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

matthiaskrgr commented Dec 7, 2025 •

edited by rustbot

Loading