Conversation
xorgy
force-pushed
the
masonry-deps-bump
branch
from
92d8dd5 to
fb3e7d8
Compare
|
I've gone ahead and run this, the primary view demo works well but I'm not 100% sure of the Masonry demo. It seems to let me focus in and type but I'd like a second set of eyes on it. |
PoignardAzur
left a comment
PoignardAzur
left a comment
There was a problem hiding this comment.
LGTM, aside from the layer handling.
| .with_child(NewWidget::new_with_props( | ||
| Flex::row() | ||
| .with_flex_child(TextInput::new("").with_auto_id(), 1.0) | ||
| .with_child(Button::new("Add task").with_auto_id()), |
There was a problem hiding this comment.
You can make this code slightly more readable with Button::with_text.
|
|
||
| [dependencies] | ||
| android-view = { path = ".." } | ||
| masonry = { git = "https://github.com/linebender/xilem" } |
There was a problem hiding this comment.
I think you could use the crates.io release instead?
There was a problem hiding this comment.
It didn't exist at that point 😉
There was a problem hiding this comment.
Oh and also that has to go in the ui-events 0.2.0 PR, because that's a separate set of changes.
| RenderRootSignal::NewLayer(..) => { | ||
| // TODO | ||
| } | ||
| RenderRootSignal::RepositionLayer(..) => { | ||
| // TODO | ||
| } | ||
| RenderRootSignal::RemoveLayer(..) => { | ||
| // TODO | ||
| } |
There was a problem hiding this comment.
If you don't know how to handle those, you should replicate the version in masonry_winit which calls RenderRoot::add_layer and the like. We should probably document this in Masonry.
|
This needs a look from somebody who is actually familiar with this stuff, because it is crashing; and crashing in a way that I am not currently set up to debug. |
2 participants
No description provided.