Skip to content

Conversation

@cathay4t
Copy link
Member

Mimicking command bridge vlan add dev br0 vid 11 self by introducing
LinkBridgeVlan::bridge_self().

Example code updated and manually tested.

@gemini-code-assist
Copy link

Summary of Changes

Hello @cathay4t, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the rtnetlink library by adding support for configuring VLAN filters directly on a bridge interface, mirroring the bridge vlan add dev <bridge_name> vid <vlan_id> self command. This allows for more comprehensive VLAN management within the library.

Highlights

  • New API for Bridge VLAN Self-Configuration: Introduced LinkBridgeVlan::bridge_self() to allow setting VLAN filters directly on the bridge interface, analogous to the bridge vlan add dev <bridge> vid <id> self command.
  • Updated Example: The set_bridge_vlan.rs example has been modified to demonstrate the usage of the new bridge_self() method, including adding a PVID and VLAN ranges to the bridge itself.
  • Enhanced Example Output: The example now prints VLAN information for both the dummy interface and the bridge interface, providing clearer feedback on the configured VLANs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring VLAN filters on the bridge device itself, which is a useful addition. The implementation is straightforward, adding a bridge_self() method and updating the example to demonstrate its usage. The changes are correct and well-implemented. I have one minor suggestion for the example code to improve its readability and make it more idiomatic.

Mimicking command `bridge vlan add dev br0 vid 11 self` by introducing
`LinkBridgeVlan::bridge_self()`.

Example code updated and manually tested.

Signed-off-by: Gris Ge <fge@redhat.com>
@cathay4t cathay4t merged commit 1f8b7da into rust-netlink:main Dec 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant