Usage examples, doctests & cosmetic tweaks#23
Merged
alxiord merged 1 commit intorust-vmm:masterfrom May 26, 2020
Merged
Conversation
alxiord
force-pushed
the
doc
branch
2 times, most recently
from
025a572 to
eb36313
Compare
| /// let cl = Cmdline::new(100); | ||
| /// let cl_cstring = CString::new(cl).unwrap(); | ||
| /// assert_eq!(cl_cstring.to_str().unwrap(), ""); | ||
| /// ``` |
Member
There was a problem hiding this comment.
#[derive(Clone)] is gone.
Member
Author
There was a problem hiding this comment.
It doesn't appear to be needed anywhere, anyway.
alxiord
force-pushed
the
doc
branch
2 times, most recently
from
4fa3da3 to
9260b47
Compare
iulianbarbu
reviewed
Mar 14, 2020
iulianbarbu
left a comment
iulianbarbu
left a comment
There was a problem hiding this comment.
This PR LGTM. Waiting for #26 to get merged will stop the discussions around struct_util module.
This was referenced Mar 16, 2020
sameo
reviewed
Mar 24, 2020
Collaborator
sameo
left a comment
sameo
left a comment
There was a problem hiding this comment.
I only have one nit, this looks pretty good and is very useful. Thanks for the PR.
src/lib.rs
Outdated
| //! This crates only supports x86_64 platforms because it implements support | ||
| //! for kernel image formats (vmlinux and bzImage) that are x86 specific. | ||
| //! Extending this crate to support other kernel image formats (e.g. ARM's Image) will make it | ||
| //! consumable by other platforms. |
Collaborator
There was a problem hiding this comment.
I'd rather keep the documentation current and modify it as part of PR #16
Collaborator
There was a problem hiding this comment.
If anything we could add the PVH support to the list.
alxiord
force-pushed
the
doc
branch
4 times, most recently
from
14813ea to
1acf932
Compare
Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
rbradford
approved these changes
May 26, 2020
jiangliu
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17