[newgrp] full implementation #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jgarzik ready for review |
jgarzik
requested changes
Oct 19, 2024
Contributor
jgarzik
left a comment
jgarzik
left a comment
There was a problem hiding this comment.
small cleanups needed. no major problems.
users/Cargo.toml
Outdated
| libc.workspace = true | ||
| chrono.workspace = true | ||
| syslog = "6.1" | ||
| libcrypt-rs = "0.1.2" |
Contributor
There was a problem hiding this comment.
Always delete the micro version from dependencies.
| /// Specifies the group ID or group name. This is a positional argument that must be provided. | ||
| #[arg(value_name = "GROUP", required = true)] | ||
| group: String, | ||
| } |
Contributor
There was a problem hiding this comment.
See datetime/cal.rs for an example of the new style of struct Args with translation support added.
Follow cal.rs style of struct Args.
users/newgrp.rs
Outdated
| None | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
use plib::curuser::login_name() ?
users/newgrp.rs
Outdated
| None | ||
| } | ||
| } | ||
| } |
users/newgrp.rs
Outdated
| setlocale(LocaleCategory::LcAll, ""); | ||
| textdomain(PROJECT_NAME)?; | ||
| bind_textdomain_codeset(PROJECT_NAME, "UTF-8")?; | ||
| let mut exit_code = 0; |
Contributor
There was a problem hiding this comment.
new style: put translation setup before Args parsing.
Contributor
Author
|
@jgarzik also ready |
jgarzik
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.