Skip to content

Conversation

@0xdx2
Copy link
Contributor

@0xdx2 0xdx2 commented Dec 24, 2025

Updated section headers and removed dependency example for presigned URLs.

#1240

Updated section headers and removed dependency example for presigned URLs.
@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs-rustfs-com Ready Ready Preview, Comment Dec 24, 2025 6:55am

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the presigned URL documentation by removing a separate dependency subsection and renumbering the remaining subsections accordingly. The changes restructure section 5.1 by eliminating the standalone dependency documentation and consolidating the content.

Key changes:

  • Removed subsection 5.1.1 "Add Dependencies" which documented the s3-presigner module requirement
  • Renumbered subsection 5.1.2 "Generate Download Link (GET)" to 5.1.1
  • Renumbered subsection 5.1.3 "Upload Presigned URL (PUT)" to 5.1.2

```

#### 5.1.2 Generate Download Link (GET)
#### 5.1.1 Generate Download Link (GET)
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the dependency example creates a gap in the documentation. The presigned URL code examples use S3Presigner from the software.amazon.awssdk.services.s3.presigner package, which requires the s3-presigner artifact. This dependency is not included in the main dependencies section (1.2), which only lists the s3 artifact.

Without this dependency information, users following the documentation will encounter compilation errors when trying to use the presigned URL examples. Either the dependency section should be retained here, or the s3-presigner dependency should be added to the main dependencies section (1.2) with a note about it being required for advanced features like presigned URLs.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants