Skip to content

Conversation

@starkillerOG
Copy link
Contributor

Split out from #1586
warn for setter input from setting decorator, since it will not work to put in a function directly in the decorator since the class object has not yet been created. Therefore always the setter_name schould be used and the binding of the setter methods schould take place when the class object gets created.

@starkillerOG starkillerOG mentioned this pull request Nov 9, 2022
@rytilahti rytilahti changed the title Warn for setter not implemented Raise exception on not-implemented @setting(setter) Nov 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1591 (d4d3c33) into master (db40713) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master    #1591   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files         156      156           
  Lines       15256    15257    +1     
  Branches     3283     3283           
=======================================
+ Hits        12340    12341    +1     
  Misses       2667     2667           
  Partials      249      249           
Impacted Files Coverage Δ
miio/devicestatus.py 90.66% <50.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Teemu R. <tpr@iki.fi>
@starkillerOG
Copy link
Contributor Author

@rytilahti ready to be merged.

@rytilahti
Copy link
Owner

Can be merged after the linting issue is fixed.

@starkillerOG
Copy link
Contributor Author

@rytilahti I think the linting issue is resolved.
No idea why my tests are beeing so flaiky.

I am calling it a day, will continue tommorow.
Thanks for the help and quick response today!

@rytilahti
Copy link
Owner

rytilahti commented Nov 9, 2022

Hehe, my pleasure, have a good one! Looks like we were quite productive with short feedback cycles :-)

The CI flakiness is something that has happened before and I thought using the codecov token would help, but this time you were also encountering this issues: #1580 - the tests will suddenly start working in 30 mins...

@rytilahti rytilahti merged commit 8be8b60 into rytilahti:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants