PHCASeeding seed volume mitigation update #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

petermic wants to merge 2 commits into sPHENIX-Collaboration:master from petermic:seed_volume_update

Contributor

petermic commented Mar 7, 2025 •

edited

Loading

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

These updates to the PHCASeeding module greatly reduce the number of seeds produced by the TPC seeding process, which in turn greatly improves the runtime of PHSimpleKFProp in exchange for a slight increase in the runtime of PHCASeeding.

A summary of the details and some low-statistics test results were presented at the March 7 tracking meeting (https://indico.bnl.gov/event/26195/).

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Michael Peters added 2 commits

March 7, 2025 02:40


          PHCASeeding seed volume mitigation update

8788b89


          fix cppcheck passed-by-value warning

4c1adac

sphenix-jenkins-ci bot commented Mar 7, 2025

Build & test report

Report for commit 8788b892ca9d3c6716134604aedf816770737ba4:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is FAILURE, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = 31.0094 / 56, and combined p-Value = 0.997297
  - 📊 QA-tracking : combined Chi2/nDoF = 732.22 / 56, and combined p-Value = 1.63768e-118
  - 📊 QA-vertexing : combined Chi2/nDoF = 89.0106 / 112, and combined p-Value = 0.946353
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = 4.1644 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = 139.357 / 50, and combined p-Value = 2.28792e-10
  - 📊 QA-vertexing : combined Chi2/nDoF = 38.5119 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is UNSTABLE, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

sphenix-jenkins-ci bot commented Mar 7, 2025

Build & test report

Report for commit 4c1adac1f7c3c566bac992f4023861675ee8e050:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is FAILURE, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = 32.8995 / 56, and combined p-Value = 0.994134
  - 📊 QA-tracking : combined Chi2/nDoF = 732.22 / 56, and combined p-Value = 1.63768e-118
  - 📊 QA-vertexing : combined Chi2/nDoF = 89.0106 / 112, and combined p-Value = 0.946353
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = 2.86995 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = 139.357 / 50, and combined p-Value = 2.28792e-10
  - 📊 QA-vertexing : combined Chi2/nDoF = 38.5133 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet