Skip to content

feat: add client_settings_override parameter to create_meeting() #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myryk31415 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add client_settings_override parameter to create_meeting() #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions sage_bbb/services/meetings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def create_meeting(
meeting_id: str,
attendee_pw: str,
moderator_pw: str,
client_settings_override: str = None,
**kwargs: Any,
) -> "Meeting":
"""
Expand All @@ -63,6 +64,7 @@ def create_meeting(
meeting_id (str): The unique identifier for the meeting.
attendee_pw (str): The password for attendees.
moderator_pw (str): The password for moderators.
client_settings_override(str): Overrides the html5-client settings.yml
**kwargs: Additional optional parameters for the meeting.

Returns:
Expand All @@ -86,8 +88,23 @@ def create_meeting(
"moderatorPW": moderator_pw,
**kwargs,
}
logger.info("Creating meeting with params: %s", params)
response = self.client.send_request("create", params)
if client_settings_override:
headers = {"Content-Type": "application/xml"}
data = (
'<modules>\n<module name="clientSettingsOverride">\n'
+ client_settings_override
+ "\n</module>\n</modules>"
)
logger.info(
"Creating meeting with params: %s; headers: %s; data: %s",
params,
headers,
data,
)
response = self.client.send_request("create", params, data, headers)
else:
logger.info("Creating meeting with params: %s", params)
response = self.client.send_request("create", params)
response_dict = self.client.parse_response(response.content)
logger.info("Meeting created successfully with ID: %s", meeting_id)
return MeetingFactory.create_meeting(response_dict)
Expand Down