Skip to content

Conversation

@rgroux
Copy link
Contributor

@rgroux rgroux commented Jul 9, 2025

update dnsutils in case we are on debian13

the package dnsutils is deprecated and replaced by bind9-dnsutils since debian 13 (trixie)

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

For Debian 13 (aka trixie), the dig tool it provided bu the bind9-dnsutils and dnsutils is now a virtual package, thats why I introduce a conditional to set dig_pkg to a correct value.

Describe the changes you're proposing

The change is

    {%- if salt['config.get']('osrelease')|int > 12 %}
    dig_pkg: bind9-dnsutils
    {%- endif %}

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@rgroux rgroux changed the title [fix] Add support for debian 13 fix(map): Add support for debian 13 Jul 9, 2025
@rgroux rgroux force-pushed the rgroux-patch-debian-dnsutils branch 2 times, most recently from 33cba53 to 20091e8 Compare July 9, 2025 10:41
rgroux added 2 commits July 9, 2025 12:45
update dnsutils in case we are on debian13

the package dnsutils is deprecated and replaced by bind9-dnsutils since debian 13 (trixie)
make it more readable space for jinja filter
@rgroux rgroux force-pushed the rgroux-patch-debian-dnsutils branch from 20091e8 to 701afb4 Compare July 9, 2025 10:45
@baby-gnu baby-gnu self-requested a review July 9, 2025 12:13
Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should modify the mapdata files because the tests are failing.

@rgroux
Copy link
Contributor Author

rgroux commented Jul 9, 2025

yes you are right, thank you.

i am fixing the test for ubuntu and debian, because of old config in mapdata file.
and add the debian 13 mapdata file too

Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@baby-gnu baby-gnu merged commit 3403e64 into saltstack-formulas:master Jul 10, 2025
13 checks passed
@saltstack-formulas-github

🎉 This PR is included in version 3.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants