[3006.x] Allow libgit2 to guess sysdir homedir successfully #68366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the generic error: _pygit2.GitError: error loading known_hosts: which is happening in certain pygit2/libgit2 versions
Merged
3 tasks
meaksh
force-pushed
the
3006.x-fix-known_hosts-error-pygit2
branch
from
d729278 to
439d3c4
Compare
twangboy
previously approved these changes
Oct 3, 2025
9 tasks
dwoz
requested changes
Oct 13, 2025
Contributor
dwoz
left a comment
dwoz
left a comment
There was a problem hiding this comment.
Otherwise his can be merged.
twangboy
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the generic error that is still seen around gitfs with certain
pygit2andlibgit2versions:After debugging
libgit2andpygit2I was able to understand what's going on here. The internalgit_sysdir__dirsstruct is populated duringlibgit2initialization, which is only triggered at the time of importingpygit2module.If the
HOMEenvironment variable is not defined when importingpygit2, then the internal guess function fromlibgit2to determine the homedir (git_sysdir_guess_home_dirs) fails to define the HOME path for the initializated stack. Therefore the above error occurs.Also once
pygit2/libgit2is instantiated, there is no way untilpygit2version 1.18.2 to explicitely redefine the internal home dir on the initializated stack, asGIT_OPT_SET_HOMEDIRwasn't implemented inpygit2until 1.18.2. See libgit2/pygit2#1409So, this PR makes sure the
HOMEenv variable is present at the time of importingpygit2atsalt.utils.gitfs.What issues does this PR fix or reference?
Fixes #64121
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes