This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Improve performance by using append to populate and grow buffer #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on PR #1, I decided to try out different strategies to replace explicit buffer management in the current version of rmarsh Generator. I tried using
bytes.Buffer,bufio.Writer, andappendand it looks like the latter is the best performing solution.Here are the original performance numbers for manual buffer management in master:
And here's the improved performance after switching to
append:The
bytes.Bufferandbufio.Writerbranches were much slower, so I didn't pursue those solutions. However, if you'd like to take a look, they are here:https://github.com/rykov/rmarsh/tree/buf-bytes
https://github.com/rykov/rmarsh/tree/buf-bufio