Skip to content

Conversation

@rennkater
Copy link

added import of environment variables BLAZECTL_USER and BLAZECTL_USER to avoid visible credentials in process list

@alexanderkiel
Copy link
Member

Looks good, can you please update the usage output in the README?

@rennkater
Copy link
Author

Looks good, can you please update the usage output in the README?

Done, I thought that was autogenerated.
Additional to cobra for cli flags one could use viper which would probably would have generated that, but I did not quickly see how to use viper efficiently. Appeared to be overkill.

Copy link
Member

@alexanderkiel alexanderkiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Viper is a mid term goal. Especially for config files. But reading the env vars by hand is ok for now.

- read environment variables BLAZECTL_USER and BLAZECTL_USER to avoid visible credentials in process list
- added new section on environment variables to README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants