fix(helm-publish): fix secrets reference in if condition#1
Conversation
GitHub Actions doesn't allow direct secrets references in `if:` conditions for reusable workflows. Move the secret access to an environment variable and check it at runtime instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughModified the Helm publish workflow's GPG key import step to use conditional logic with an environment variable instead of relying on a step-level condition. The GPG key is now imported only if the environment variable is non-empty, otherwise a warning is logged and the step proceeds. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
GitHub Actions doesn't allow direct secrets references in
if:conditions for reusable workflows. This PR moves the secret access to an environment variable and checks it at runtime.Changes
Import GPG keystep to check for GPG key at runtime instead of inif:conditionTest plan
Summary by CodeRabbit