Skip to content

Conversation

@raspopov
Copy link

Now, activate the data display settings dialog by double-clicking the left or right mouse button on any unoccupied space inside the registers window, similar to the register write dialog and register description editing dialog.

Fixes #66

@sanny32 sanny32 self-assigned this Dec 19, 2025
@sanny32 sanny32 changed the base branch from main to dev December 19, 2025 06:14
@sanny32 sanny32 self-requested a review December 19, 2025 06:16
Copy link
Owner

@sanny32 sanny32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now double click show Display Definition dialog if i clicking on status text. Is it expected behavior?

@raspopov
Copy link
Author

For now double click show Display Definition dialog if i clicking on status text. Is it expected behavior?

Yes, that's correct. Since this window uses double-clicking as the main user interaction, it's okay if it takes up all the free space from other active areas. This behavior does not conflict with any other behavior at this time. If the status text has its own dialog in the future, it will be activated first and no additional changes will be required.

@sanny32
Copy link
Owner

sanny32 commented Dec 22, 2025

Yes, that's correct.

I consider this behavior to be inappropriate. Therefore, I cannot accept this PR.

@sanny32 sanny32 closed this Dec 22, 2025
@raspopov
Copy link
Author

I consider this behavior to be inappropriate. Therefore, I cannot accept this PR.

Could you please clarify? Do you want the call to be accessible only at the top of the window, above the splitter?

@sanny32 sanny32 reopened this Dec 23, 2025
@sanny32 sanny32 self-requested a review December 23, 2025 05:53
Copy link
Owner

@sanny32 sanny32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call to be accessible only at the top of the window, above the splitter.

Now, activate the data display settings dialog by double-clicking the
left or right mouse button on top unoccupied space inside the registers
window, similar to the register write dialog and register description
editing dialog.

Fixes sanny32#66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

💡 Optimize access to the settings dialog

2 participants