Skip to content

Conversation

@raspopov
Copy link

  • Unused Qt libraries and plugins have been removed.
  • Optimal distribution compression has been set.
  • The vc_redist file and temporary files are now removed after installation.
  • The undefined VERSIONMAJOR and VERSIONMINOR variables have been fixed, which led to the incorrect zeroed version being written to the Uninstaller section of the Windows registry.
  • A version section has been added to the installer.

The distribution size has been reduced by ~7 MB.

🌟🔔🎁{ }🎄; Merry Christmas! 😎

@sanny32 sanny32 self-requested a review December 25, 2025 05:28
Copy link
Owner

@sanny32 sanny32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete vc_redist because users should be able to copy the application to a flash drive and run it from the flash drive, and some systems may not contain the libraries from vc_redist. Users should be able to install additional libraries from vc_redist.

@raspopov
Copy link
Author

Do not delete vc_redist because users should be able to copy the application to a flash drive and run it from the flash drive, and some systems may not contain the libraries from vc_redist. Users should be able to install additional libraries from vc_redist.

Let's discuss this. Why do you think users should copy the program instead of using the distribution package? This is not a portable version because installing anything on the system, including system libraries from vc_redist, is unacceptable for a portable version. Users gain nothing by copying the program manually; they only lose convenience and compatibility.

To create a portable version, I suggest changing the compiler from VS 2019 to the official Qt compiler, MinGW 8.1 or LLVM 17. This will allow us to include C++ libraries in the delivery set as files that don't require installation.

- Unused Qt libraries and plugins have been removed.
- Optimal distribution compression has been set.
- The vc_redist file and temporary files are now removed after
  installation.
- The undefined VERSIONMAJOR and VERSIONMINOR variables have been fixed,
  which led to the incorrect zeroed version being written to the
  Uninstaller section of the Windows registry.
- A version section has been added to the installer.

The distribution size has been reduced by 7 MB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants