add Java 9 test #179
add Java 9 test #179
Conversation
ashawley
left a comment
ashawley
left a comment
There was a problem hiding this comment.
We're waiting on the new sbt 0.13.17, and possibly a new sbt scala module plugin release.
| fi | ||
| sbt "$publishVersion" "$publishScalaVersion" clean update +test +publishLocal $extraTarget | ||
| sbt -Dsbt.scala.version=2.10.7 "$publishVersion" "$publishScalaVersion" clean update +test +publishLocal $extraTarget |
There was a problem hiding this comment.
I saw @SethTisue mention this, but I'd rather avoid breaking fix the build for people.
| )) | ||
| .getOrElse(Map.empty) | ||
| } | ||
| } |
There was a problem hiding this comment.
This refactoring actually causes an NPE to silently succeed with the doc task. It's better if the task still fails, IMO.
This part of the sbt config may get replaced by https://github.com/ThoughtWorksInc/sbt-api-mappings
There was a problem hiding this comment.
Sorry, I take this back. We will need to degrade when the Java boostrap classpath is unavailable. I'll be using this PR as a basis for fixing Java 9 including the external doc linking.
|
waiting on scala/sbt-scala-module#32 |
|
Continuing in #180 |
3 participants
fix #173