Fix unused patvar #24312
Merged
Fix unused patvar #24312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
tweak/quotes-impl-patvar
branch
from
9c218d0 to
fa02c77
Compare
som-snytt
force-pushed
the
tweak/quotes-impl-patvar
branch
from
fa02c77 to
f1cfa00
Compare
Contributor
Author
|
Still needs a failing test for the broken code. The last commit is for comments previously munged by pasting. |
som-snytt
force-pushed
the
tweak/quotes-impl-patvar
branch
from
f1cfa00 to
ac2cfe9
Compare
Contributor
Is it ready to review without it? |
som-snytt
force-pushed
the
tweak/quotes-impl-patvar
branch
from
ac2cfe9 to
ee060b1
Compare
Contributor
Author
|
I dropped the clever refactor of the method and only fixed the obvious typo. I saved the refactor for when I have a test to rely on. (It would still be nice to have a test.) |
lidaisy
pushed a commit
to lidaisy/scala3
that referenced
this pull request
Dec 5, 2025
Wrong patvar was used. Experimented with the idiom. Noticed while compiling with `-Wunused:all`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong patvar was used. Experimented with the idiom.
Noticed while compiling with
-Wunused:all.