Skip to content

Remove TODO in MatchReducer #24488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbovel merged 2 commits into from
Dec 4, 2025
Merged

Remove TODO in MatchReducer #24488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04531c9
Delete TODO on MatchReducer
Lluc24 Dec 4, 2025
ae1381a
Add reference to #24488 in `MatchReducer`'s documentation
mbovel Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions compiler/src/dotty/tools/dotc/core/TypeComparer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3594,10 +3594,7 @@ object MatchReducer:
case Stuck => "Stuck"
case NoInstance(fails) => "NoInstance(" ~ Text(fails.map(p.toText(_) ~ p.toText(_)), ", ") ~ ")"

/** A type comparer for reducing match types.
* TODO: Not sure this needs to be a type comparer. Can we make it a
* separate class?
*/
/** A type comparer for reducing match types. */
class MatchReducer(initctx: Context) extends TypeComparer(initctx) {
import MatchReducer.*

Expand Down
Loading