Skip to content

Dealias in isSimpleThrowable check #24744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eejbyfeldt wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Dealias in isSimpleThrowable check #24744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/transform/TryCatchPatterns.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class TryCatchPatterns extends MiniPhase {
case _ => isDefaultCase(cdef)
}

private def isSimpleThrowable(tp: Type)(using Context): Boolean = tp.stripped match {
private def isSimpleThrowable(tp: Type)(using Context): Boolean = tp.strippedDealias match {
case tp @ TypeRef(pre, _) =>
(pre == NoPrefix || pre.typeSymbol.isStatic) && // Does not require outer class check
!tp.symbol.is(Flags.Trait) && // Traits not supported by JVM
Expand Down
10 changes: 10 additions & 0 deletions tests/run/i24357.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
class E1 extends Exception
class E2 extends Exception

type E1or2 = E1 | E2

@main def Test =
try throw new Exception {}
catch
case e: E1or2 => assert(e.isInstanceOf[E1or2])
case _ => ()
Comment on lines +9 to +10
Copy link
Member

@hamzaremmal hamzaremmal Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the test more robust.

Suggested change
case e: E1or2 => assert(e.isInstanceOf[E1or2])
case _ => ()
case e: E1or2 => assert(false)
case _ => ()

Loading