Open
Conversation
Now unloading a sequence does not delete the information about the sequence from the dataset - it just release the loaded data.
Author
Author
|
Ah, and a use case: Previously, this code gives first iteration over the whole dataset, then no iteration, since the information about the sequences was gone: And now it's possible to iterate over the dataset multiple times, without reinitializing dataset variable: |
Contributor
|
Looks like a better fix to me. I think @xpchuan-95 can merge it? Still it would be better to not have to re-initialize the sequence or to not even need this unloading mechanism at all. But I guess this would require a new loading concept, therefore the solutions provided by this pull request and #76 are sufficient enough for a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now unloading a sequence does not delete the information about the sequence from the dataset - it just release the loaded data.