Skip to content

fix validation step for tutorial agents #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoxyFarhad merged 2 commits into from
Jan 15, 2026
Merged

fix validation step for tutorial agents #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0c8db
fix validation
RoxyFarhad Jan 15, 2026
dc01eae
Merge branch 'main' into fix/validation-bug
RoxyFarhad Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions .github/workflows/build-and-push-tutorial-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,13 @@ jobs:
echo "Agent name set to $AGENT_NAME"

- name: Login to GitHub Container Registry
# Only login if we're going to push (main branch or rebuild_all)
if: ${{ github.event_name == 'push' || inputs.rebuild_all }}
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and Conditionally Push Agent Image
- name: Build Agent Image
env:
REGISTRY: ghcr.io
run: |
Expand All @@ -187,27 +185,22 @@ jobs:
if [ "${{ github.event_name }}" = "push" ] || [ "${{ inputs.rebuild_all }}" = "true" ]; then
SHOULD_PUSH=true
VERSION_TAG="latest"
echo "🚀 Building and pushing agent: ${{ matrix.agent_path }}"
echo "🚀 Building agent (will push after validation): ${{ matrix.agent_path }}"
else
SHOULD_PUSH=false
VERSION_TAG="${{ github.sha }}"
echo "🔍 Validating build for agent: ${{ matrix.agent_path }}"
echo "🔍 Building agent for validation: ${{ matrix.agent_path }}"
fi

# Build command - add --push only if we should push
# Always build locally first (without push)
BUILD_ARGS="--manifest ${{ matrix.agent_path }}/manifest.yaml --registry ${REGISTRY} --tag ${VERSION_TAG} --platforms linux/amd64,linux/arm64 --repository-name ${REPOSITORY_NAME}"

if [ "$SHOULD_PUSH" = "true" ]; then
agentex agents build $BUILD_ARGS --push
echo "✅ Successfully built and pushed: ${REGISTRY}/${REPOSITORY_NAME}:${VERSION_TAG}"
# Set full image name for validation step
echo "FULL_IMAGE=${REGISTRY}/${REPOSITORY_NAME}:${VERSION_TAG}" >> $GITHUB_ENV
else
agentex agents build $BUILD_ARGS
echo "✅ Build validation successful for: ${{ matrix.agent_path }}"
# Set full image name for validation step (local build)
echo "FULL_IMAGE=${REGISTRY}/${REPOSITORY_NAME}:${VERSION_TAG}" >> $GITHUB_ENV
fi
agentex agents build $BUILD_ARGS
echo "✅ Successfully built: ${REGISTRY}/${REPOSITORY_NAME}:${VERSION_TAG}"

# Set environment variables for subsequent steps
echo "FULL_IMAGE=${REGISTRY}/${REPOSITORY_NAME}:${VERSION_TAG}" >> $GITHUB_ENV
echo "SHOULD_PUSH=${SHOULD_PUSH}" >> $GITHUB_ENV

- name: Validate agent image
run: |
Expand Down Expand Up @@ -281,6 +274,14 @@ jobs:

echo "✅ All validations passed for: $FULL_IMAGE"

- name: Push Agent Image
if: env.SHOULD_PUSH == 'true'
run: |
FULL_IMAGE="${{ env.FULL_IMAGE }}"
echo "🚀 Pushing validated image: $FULL_IMAGE"
docker push "$FULL_IMAGE"
echo "✅ Successfully pushed: $FULL_IMAGE"

deprecate-agents:
name: "Deprecate Removed Agents"
runs-on: ubuntu-latest
Expand Down