✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes by DarkIsDude · Pull Request #6043 · scality/cloudserver

DarkIsDude · 2026-01-08T16:02:38Z

Related issues

https://scality.atlassian.net/browse/CLDSRV-813

codecov · 2026-01-08T16:11:00Z

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.79%. Comparing base (ccaf400) to head (09c36ce).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/bucketGet.js	72.72%	6 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/metadataSearch.js	`76.38% <100.00%> (+0.33%)`	⬆️
lib/routes/veeam/list.js	`97.50% <ø> (ø)`
lib/api/bucketGet.js	`92.66% <72.72%> (-3.46%)`	⬇️

@@                 Coverage Diff                 @@
##           development/9.1    #6043      +/-   ##
===================================================
- Coverage            83.81%   83.79%   -0.02%     
===================================================
  Files                  191      191              
  Lines                12328    12350      +22     
===================================================
+ Hits                 10333    10349      +16     
- Misses                1995     2001       +6

Flag	Coverage Δ
file-ft-tests	`66.88% <30.43%> (-0.08%)`	⬇️
kmip-ft-tests	`27.02% <0.00%> (-0.05%)`	⬇️
mongo-v0-ft-tests	`68.20% <34.78%> (-0.07%)`	⬇️
mongo-v1-ft-tests	`68.19% <34.78%> (-0.07%)`	⬇️
multiple-backend	`34.27% <26.08%> (-0.03%)`	⬇️
sur-tests	`34.58% <4.34%> (-0.91%)`	⬇️
sur-tests-inflights	`36.49% <4.34%> (-0.06%)`	⬇️
unit	`69.66% <69.56%> (+0.04%)`	⬆️
utapi-v2-tests	`33.40% <26.08%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lib/api/bucketGet.js

tests/functional/aws-node-sdk/test/object/mpuVersion.js

francoisferrand · 2026-01-11T20:25:20Z

tests/functional/aws-node-sdk/test/object/mpuVersion.js

    for (const version of versions) {
        if (version.value) {
            version.value.uploadId = undefined;
+            version.value.restoreStatus = undefined;


why do we need to clear RestoreStatus from all of these tests?

RestoreStatus is only set by cold storage, so will not be set in most case : so seems best to keep this "as is" and handle the cold-storage tests

The issue is that we call directly metadata.listObject in tests. Regarding arsenal PR, the restoreStatus attribute will be returned as soon as we have an archive field.

And we have a diff. The issue is that the versionBefore do a fakeMetadataArchive that update the object. So the version before contains it. This is not done in the second one (versionAfter) and so we have this diff. Regarding the test, that make sense and our API don't change, here we have this diff just because we don't call our API but internal arsenal function.

francoisferrand · 2026-01-11T20:26:48Z

tests/functional/aws-node-sdk/test/object/putVersion.js

+
+    for (const version of versions) {
+        if (version.value) {
+            version.value.restoreStatus = undefined;


why do we need to clear RestoreStatus in every test?

all APIs should behave the same as before, so you should not need to tweak the tests
(and resetting restoreStatus may be expected -if anywhere- only in tests where you do actually invoke the list object v2 api with optional attributes)

#6043 (comment)

tests/unit/api/bucketGet.js

lib/api/bucketGet.js

tests/functional/aws-node-sdk/test/bucket/get.js

Issue: CLDSRV-813

…e and switch to a subobject usermetadata Issue: CLDSRV-813

Issue: CLDSRV-813

bert-e · 2026-02-04T16:15:35Z

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-02-04T16:15:40Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-813 contains:

9.2.25
9.3.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.1.11
9.2.25
9.3.0

Please check the Fix Version/s of CLDSRV-813, or the target
branch of this pull request.

Issue: CLDSRV-813

DarkIsDude · 2026-02-04T17:17:14Z

/create_pull_requests

bert-e · 2026-02-04T17:17:24Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.2/feature/CLDSRV-813/optional-attributes-response with contents from feature/CLDSRV-813/optional-attributes-response
and development/9.2.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.2/feature/CLDSRV-813/optional-attributes-response origin/development/9.2
 git merge origin/feature/CLDSRV-813/optional-attributes-response
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.2/feature/CLDSRV-813/optional-attributes-response

The following options are set: create_pull_requests

bert-e · 2026-02-04T17:42:15Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.3/feature/CLDSRV-813/optional-attributes-response with contents from w/9.2/feature/CLDSRV-813/optional-attributes-response
and development/9.3.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.3/feature/CLDSRV-813/optional-attributes-response origin/development/9.3
 git merge origin/w/9.2/feature/CLDSRV-813/optional-attributes-response
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.3/feature/CLDSRV-813/optional-attributes-response

The following options are set: create_pull_requests

bert-e · 2026-02-04T18:01:37Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge feature/CLDSRV-813/optional-attributes-response into
development/9.1
w/9.2/feature/CLDSRV-813/optional-attributes-response will be merged into development/9.2 (pull request INTEGRATION [PR#6043 > development/9.2] ✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6074)
w/9.3/feature/CLDSRV-813/optional-attributes-response will be merged into development/9.3 (pull request INTEGRATION [PR#6043 > development/9.3] ✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6075)

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0

Follow integration pull requests if you would like to be notified of
build statuses by email.

The following options are set: create_pull_requests

bert-e · 2026-02-04T18:01:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_pull_requests

DarkIsDude self-assigned this Jan 8, 2026

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch 3 times, most recently from 1fde211 to a8eba02 Compare January 9, 2026 11:13

DarkIsDude requested review from a team, benzekrimaha and maeldonn January 9, 2026 11:46

francoisferrand reviewed Jan 11, 2026

View reviewed changes

lib/api/bucketGet.js Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/object/mpuVersion.js Outdated Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

tests/unit/api/bucketGet.js Show resolved Hide resolved

francoisferrand reviewed Jan 11, 2026

View reviewed changes

tests/unit/api/bucketGet.js Show resolved Hide resolved

DarkIsDude commented Jan 12, 2026

View reviewed changes

tests/unit/api/bucketGet.js Show resolved Hide resolved

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch 3 times, most recently from 3711fb9 to 037e011 Compare January 13, 2026 15:03

DarkIsDude requested a review from francoisferrand January 13, 2026 15:39

benzekrimaha reviewed Jan 13, 2026

View reviewed changes

lib/api/bucketGet.js Show resolved Hide resolved

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch 3 times, most recently from 0d9a18a to 3ceb257 Compare January 14, 2026 14:41

DarkIsDude requested a review from benzekrimaha January 14, 2026 14:57

maeldonn removed their request for review January 14, 2026 17:00

benzekrimaha reviewed Jan 14, 2026

View reviewed changes

tests/functional/aws-node-sdk/test/bucket/get.js Outdated Show resolved Hide resolved

francoisferrand approved these changes Jan 19, 2026

View reviewed changes

DarkIsDude force-pushed the feature/CLDSRV-812/list-objects-v2-optional-permissions branch from 9872996 to ccaf400 Compare February 4, 2026 12:58

DarkIsDude added 2 commits February 4, 2026 14:00

✨ update the XML response to support Optional attributes

1e5fe9f

Issue: CLDSRV-813

✅ add new tests for the new response logic

e38e9c3

Issue: CLDSRV-813

DarkIsDude added 7 commits February 4, 2026 14:00

✨ update Veeam route to pass the new params

1eff557

Issue: CLDSRV-813

✨ update metadataSearch to pass the right arguments

f4c8c5c

Issue: CLDSRV-813

✨ process attributes as lower case

2fbe06e

Issue: CLDSRV-813

♻️ parse optional attributes instead of all key to improve performanc…

20699f5

…e and switch to a subobject usermetadata Issue: CLDSRV-813

✅ create a new functional tests

4920538

Issue: CLDSRV-813

✅ add new functional tests to cover more use case

6263b2d

Issue: CLDSRV-813

✅ run test only if vault is available

66a8264

Issue: CLDSRV-813

DarkIsDude force-pushed the feature/CLDSRV-813/optional-attributes-response branch from 62c1ce8 to 66a8264 Compare February 4, 2026 13:00

🔖 release CloudServer 9.1.11

870204d

Issue: CLDSRV-813

Base automatically changed from feature/CLDSRV-812/list-objects-v2-optional-permissions to development/9.1 February 4, 2026 16:15

♻️ rename test to be more clear

09c36ce

Issue: CLDSRV-813

DarkIsDude requested a review from benzekrimaha February 4, 2026 16:42

bert-e mentioned this pull request Feb 4, 2026

INTEGRATION [PR#6043 > development/9.2] ✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6074

Open

bert-e mentioned this pull request Feb 4, 2026

INTEGRATION [PR#6043 > development/9.3] ✨(CLDSRV-813) update CloudServer XML ListObjectsV2 to support optional attributes #6075

Open

Conversation

DarkIsDude commented Jan 8, 2026

Related issues

Uh oh!

codecov bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

francoisferrand Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

francoisferrand Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DarkIsDude Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bert-e commented Feb 4, 2026

Hello darkisdude,

Uh oh!

bert-e commented Feb 4, 2026

Incorrect fix version

Uh oh!

DarkIsDude commented Feb 4, 2026

Uh oh!

bert-e commented Feb 4, 2026

Conflict

Uh oh!

bert-e commented Feb 4, 2026

Conflict

Uh oh!

bert-e commented Feb 4, 2026

Integration data created

Uh oh!

bert-e commented Feb 4, 2026

Waiting for approval

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 8, 2026 •

edited

Loading

francoisferrand Jan 11, 2026 •

edited

Loading

francoisferrand Jan 11, 2026 •

edited

Loading