-
Notifications
You must be signed in to change notification settings - Fork 8
ci: change fallback version to 3.12-3.14 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found out from chatgpt hat this default is ignored if it is a workflow_call. This is why the matrix didn't fall back when inputs.python_version wasnt passed correctly in our workflow. Good thing too or we wouldn't have discovered the problem.
The fix is to put it directly in the python_version: field after ||.
But while we debug why that variable is not being passed correctly, we may not want any fallback, so let's just delete it for now
|
@sbillinge I have made that commit here, unfortunately, there seems to be some subprocess of the workflow that enforce to this repo instead of my local fork. So, I cannot test it directly unless I figure out all subprocesses in the workflow and direct them to my forked repo. |
sbillinge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to put in an echo of where the matrix is coming from for debuggong later? Something like "Python versions obtained dynamically: {{ inputs.python_versions }}" or something like that? Of it is empty, then trigger another message of what it is falling back to
|
Thanks, this looks good. Were you able to figure out why the dynamic |
|
@sbillinge Well, I'm still stuck on in the subprocess the workflow would start to use the The error message confirms that it would still use this repository's branch to test on my local: which is the same error for your test on release |
|
But apart from that, for the potential problem of not getting right version here, I'm suspecting it is because we have incompatible definition in And then in the job we still take However, in the subprocess, after getting into I'm not sure whether we need to keep the type of |
|
I think if you can make a testing rig where you write a workflow that calls your workflow in the same way that we do in our main one and then trigger it that way, could that work for testing maybe? |

Closes #213 @sbillinge Ready to review