Merged
Conversation
…s in the knapsack model
…for fixed and aggregated variables
…, and example shiftbound.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…standing of variable aggregation logic
…fvz185/PySCIPOpt into feature/extend-presolver-plugin
…ture/extend-presolver-plugin
Contributor
|
/tmp/pip-build-env-v4vbe1j_/overlay/lib/python3.11/site-packages/setuptools/config/_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning: `project.license` as a TOML table is deprecated
!!
********************************************************************************
Please use a simple string containing a SPDX expression for `project.license`. You can also use `project.license-files`. (Both options available on setuptools>=77.0.0).
By 2027-Feb-18, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
corresp(dist, value, root_dir)
/tmp/pip-build-env-v4vbe1j_/overlay/lib/python3.11/site-packages/setuptools/config/_apply_pyprojecttoml.py:61: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: MIT License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
dist._finalize_license_expression()
/tmp/pip-build-env-v4vbe1j_/overlay/lib/python3.11/site-packages/setuptools/dist.py:765: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!
********************************************************************************
Please consider removing the following classifiers in favor of a SPDX license expression:
License :: OSI Approved :: MIT License
See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
********************************************************************************
!!
self._finalize_license_expression()https://github.com/scipopt/PySCIPOpt/actions/runs/21543124063/job/62080594514?pr=1181#step:6:55 |
Zeroto521
reviewed
Feb 3, 2026
Comment on lines
134
to
158
| setup( | ||
| name="PySCIPOpt", | ||
| version="6.0.0", | ||
| version="6.1.0", | ||
| description="Python interface and modeling environment for SCIP", | ||
| long_description=long_description, | ||
| long_description_content_type="text/markdown", | ||
| url="https://github.com/SCIP-Interfaces/PySCIPOpt", | ||
| author="Zuse Institute Berlin", | ||
| author_email="scip@zib.de", | ||
| license="MIT", | ||
| classifiers=[ | ||
| "Development Status :: 4 - Beta", | ||
| "Intended Audience :: Science/Research", | ||
| "Intended Audience :: Education", | ||
| "License :: OSI Approved :: MIT License", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Cython", | ||
| "Topic :: Scientific/Engineering :: Mathematics", | ||
| ], | ||
| ext_modules=extensions, | ||
| packages=find_packages(where="src"), | ||
| package_dir={"pyscipopt": packagedir}, | ||
| package_data={"pyscipopt": ["scip.pyx", "scip.pxd", "*.pxi", "scip/lib/*"]}, | ||
| include_package_data=True, | ||
| ) |
Contributor
There was a problem hiding this comment.
setup.py is duplicated to pyproject.toml.
We can keep the minimal items for setup.py.
Suggested change
| setup( | |
| version="6.1.0", | |
| ext_modules=extensions, | |
| packages=find_packages(where="src"), | |
| package_dir={"pyscipopt": packagedir}, | |
| package_data={"pyscipopt": ["scip.pyx", "scip.pxd", "*.pxi", "scip/lib/*"]}, | |
| include_package_data=True, | |
| ) | |
Member
Author
|
Thank you for the help, @Zeroto521 . This is one part I don't particularly enjoy about maintaining SCIP. Would you be willing to make some of the changes for the release? |
Contributor
Sorry for that, I don't have permission to access this PR. |
Member
Author
|
The test pip installation is passing both on MacOS and Linux. Will release today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing a new PySCIPOpt release with the upcoming new SCIP minor version.