Codex/unlink cloud storage #1151
Open
+90
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen-set-to-0 Fix popup script menu when expand limit is zero
- Refactored sidebar menu into `SiderMenu` component - Updated `Sider` to use a Drawer on mobile (<768px) - Added hamburger button for mobile navigation - Adjusted content padding and layout for mobile view
- Refactored sidebar menu into `SiderMenu` component - Updated `Sider` to use a Drawer on mobile (<768px) - Added hamburger button for mobile navigation - Adjusted content padding and layout for mobile view - Fixed linting errors
…5106827526 Mobile Responsive UI for Options Page
…3980127985106827526 Revert "Mobile Responsive UI for Options Page"
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to unbind cloud storage accounts by introducing an "Unbind" button for cloud storage providers (Baidu Netdisk, OneDrive, Google Drive, and Dropbox).
Changes:
- Added
ClearNetDiskTokenfunction to remove cloud storage authentication tokens - Implemented unbind UI with confirmation dialog in the file system parameters component
- Added internationalization support for unbind-related messages across 8 languages
- Fixed menu expansion logic to properly handle unlimited expansion when
menuExpandNumis 0
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/filesystem/auth.ts | Exports NetDiskType and adds ClearNetDiskToken function to clear stored tokens |
| src/pages/components/FileSystemParams/index.tsx | Adds unbind button with confirmation dialog for cloud storage providers |
| src/pages/components/ScriptMenuList/index.tsx | Fixes menu expansion logic to handle zero limit case |
| src/locales/*/translation.json | Adds translation keys for unbind functionality across all supported languages |
| }, | ||
| ]; | ||
| const netDiskTypeMap: Partial<Record<FileSystemType, NetDiskType>> = { | ||
| "baidu-netdsik": "baidu", |
There was a problem hiding this comment.
Corrected spelling of 'netdsik' to 'netdisk'.
| }) => { | ||
| const fsParams = FileSystemFactory.params(); | ||
| const { t } = useTranslation(); | ||
| const actionButtons = [...actionButton]; |
There was a problem hiding this comment.
Creating a shallow copy of actionButton array and then mutating it with push is unnecessary. Consider using array concatenation or spread operator at the render site to avoid mutation and make the code more functional.
| const key = `netdisk:token:${netDiskType}`; | ||
| try { | ||
| await localStorageDAO.delete(key); | ||
| } catch (_) { |
There was a problem hiding this comment.
The unused error parameter should be named _error instead of _ to indicate it's an intentionally unused error value, following common TypeScript conventions.
CodFrm
reviewed
Jan 21, 2026
Comment on lines
187
to
197
| const hasExpandLimit = menuExpandNum > 0; | ||
|
|
||
| const visibleMenus = useMemo(() => { | ||
| // 当menuExpandNum为0时，跟随 isActive 状态显示全部菜单 | ||
| const m = scriptMenus?.group || []; | ||
| if (menuExpandNum === 0 && isActive) { | ||
| return m; | ||
| } | ||
| if (!hasExpandLimit) return m; | ||
| return m.length > menuExpandNum && !isExpand ? m.slice(0, menuExpandNum) : m; | ||
| }, [scriptMenus?.group, isExpand, menuExpandNum, isActive]); | ||
| }, [scriptMenus?.group, hasExpandLimit, isExpand, menuExpandNum]); | ||
|
|
||
| const shouldShowMore = useMemo( | ||
| () => menuExpandNum > 0 && scriptMenus?.group?.length > menuExpandNum, | ||
| [scriptMenus?.group, menuExpandNum] | ||
| () => hasExpandLimit && scriptMenus?.group?.length > menuExpandNum, | ||
| [hasExpandLimit, scriptMenus?.group, menuExpandNum] |
Member
There was a problem hiding this comment.
0 indicates a hidden menu; if you want to show all menu items, you can set a much larger value.
Comment on lines
+52
to
+59
| const netDiskTypeMap: Partial<Record<FileSystemType, NetDiskType>> = { | ||
| "baidu-netdsik": "baidu", | ||
| onedrive: "onedrive", | ||
| googledrive: "googledrive", | ||
| dropbox: "dropbox", | ||
| }; | ||
| const netDiskType = netDiskTypeMap[fileSystemType]; | ||
| const netDiskName = fileSystemList.find((item) => item.key === fileSystemType)?.name; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概述 Descriptions
Solve the issue of not having a cloud unlink button.