feat: improve sequencer metrics

[georgehao]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

✅ 2 untouched benchmarks

---

_{Comparing feat/improve_sequencer_metrics (de0274d) with main (c3ec1a2)¹}

Footnotes

1. No successful run was found on main (dab4f84) during the generation of this report, so c3ec1a2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[frisitano]

I've added some comments inline. On a high level I think we should record the following metrics:

• block_building_duration: the time it takes to build a non-empty block
• empty_block_building_duration: the time it takes to build an empty block
• consecutive_block_interval: the time between two consecutive blocks that are added to the canonical chain.

I'm not sure if you had a different idea about these metrics to please let me know if I have misunderstood something.

[georgehao]

• block_building_duration: the time it takes to build a non-empty block
• empty_block_building_duration: the time it takes to build an empty block

Oh, I understand it is that:

if I want to check the block building duration, I will check the whole block building duration, then check the no-empty block building duration, then I will get the conclusion for it ( because the empty block building will always have a constant value, no sense to display this alone, and can calculate it from the all_block_building_duration and block_building_duration)

What do you think?

[frisitano]

Added a comment inline. I think the description you provided does not match the code.

[frisitano]

I think this solution doesn't work as expected. Please let me know if I made a mistake in my understanding.