Pins distributed; better categorical handing for points parser
#1061
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaMarconato
changed the title
distributed; better categorical handing for points parser
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
+ Coverage 92.21% 92.24% +0.02%
==========================================
Files 49 49
Lines 7593 7594 +1
==========================================
+ Hits 7002 7005 +3
+ Misses 591 589 -2
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change
The latest
daskdistributedcannot be used with the second latestdask(the latestdaskis not supported because it's not supported inome-zarr-py). This PR adds an upper bound.Main change
Improves performance of points parsing by eliminating superfluous conversions to
categoricalfor columns that are not thefeature_keycolumn. Also warns the user that converting a column to categorical prior to parsing (by preserving the known status of the categories), improves performance.Tested with Xenium data (performance of point parsing improves ~20x for ~100 million transcripts): .