Skip to content

Conversation

@timtreis
Copy link
Member

@timtreis timtreis commented Mar 28, 2025

@timtreis timtreis marked this pull request as draft March 28, 2025 16:52
@timtreis timtreis added enhancement ✨ New feature or request image 🔬 squidpy2.0 Everything releated to a Squidpy 2.0 release sdata compat 🌌 release-added labels Mar 28, 2025
@timtreis
Copy link
Member Author

timtreis commented May 16, 2025

Note to self:

  • Doesn't correctly parse str names of channels
    INFO Calculating 'cpmeasure' correlation features between channels '0' and '1'.

  • Should show, for permutations, the total number of iterations (in general, the progress bar should contain a (step n out m) readout so one can know how far in the featurisation is. Can easily take more than a day given the amount of cells and cpu_cores. Should also maybe show the total runtime so far for the steps that are done

  • Fails if labels and image don't have the same dimensions, despite transformation to align them

@timtreis timtreis marked this pull request as ready for review September 11, 2025 20:15
@pakiessling
Copy link

Tried it out and it worked very well!

One quality of life feature would be the ability to specify channels that should be measured.

Often times there are channels that are not informative / used only for segmentation and those slow down the calculations.

@pakiessling
Copy link

Ah I noticed another thing.

For the created morphology table .uns["spatialdata_attrs"] needs to be set, otherwise this runs into problem when querying the Spatialdata afterwards.

timtreis and others added 6 commits January 27, 2026 13:46
- Resolved dependency conflicts (updated to zarr>=3)
- Moved exp module to experimental to align with main
- Integrated CellProfiler features into experimental module
- Added centrosome and cp_measure dependencies
Moved calculate_image_features from experimental._feature to
experimental.im._feature to follow the existing module structure.
Now accessible as squidpy.experimental.im.calculate_image_features
- Test basic feature calculation with shapes
- Test copy vs inplace behavior
- Test error cases for invalid keys
- Uses sdata_hne fixture with skimage:label for fast execution
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 51.54185% with 220 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.34%. Comparing base (f976fb0) to head (8da641b).

Files with missing lines Patch % Lines
src/squidpy/experimental/im/_feature.py 51.54% 185 Missing and 35 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   66.21%   65.34%   -0.88%     
==========================================
  Files          44       45       +1     
  Lines        7163     7617     +454     
  Branches     1217     1330     +113     
==========================================
+ Hits         4743     4977     +234     
- Misses       1943     2128     +185     
- Partials      477      512      +35     
Files with missing lines Coverage Δ
src/squidpy/experimental/im/_feature.py 51.54% <51.54%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato
Copy link
Member

Looking forward to this PR 👀🥸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ New feature or request image 🔬 release-added sdata compat 🌌 squidpy2.0 Everything releated to a Squidpy 2.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants