-
Notifications
You must be signed in to change notification settings - Fork 104
[EXPERIMENTAL]: Integrate cp-measure #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…to feature/add_cpmeasure
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…to feature/add_cpmeasure
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Note to self:
|
|
Tried it out and it worked very well! One quality of life feature would be the ability to specify channels that should be measured. Often times there are channels that are not informative / used only for segmentation and those slow down the calculations. |
|
Ah I noticed another thing. For the created morphology table .uns["spatialdata_attrs"] needs to be set, otherwise this runs into problem when querying the Spatialdata afterwards. |
- Resolved dependency conflicts (updated to zarr>=3) - Moved exp module to experimental to align with main - Integrated CellProfiler features into experimental module - Added centrosome and cp_measure dependencies
for more information, see https://pre-commit.ci
Moved calculate_image_features from experimental._feature to experimental.im._feature to follow the existing module structure. Now accessible as squidpy.experimental.im.calculate_image_features
- Test basic feature calculation with shapes - Test copy vs inplace behavior - Test error cases for invalid keys - Uses sdata_hne fixture with skimage:label for fast execution
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
- Coverage 66.21% 65.34% -0.88%
==========================================
Files 44 45 +1
Lines 7163 7617 +454
Branches 1217 1330 +113
==========================================
+ Hits 4743 4977 +234
- Misses 1943 2128 +185
- Partials 477 512 +35
🚀 New features to boost your workflow:
|
|
Looking forward to this PR 👀🥸 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Associated notebook: https://github.com/scverse/squidpy_notebooks/blob/add_cpmeasure_notebook/tutorials/tutorial_cpmeasure.ipynb