Add support of CONNECTION_METADATA_CHANGE event #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for the CONNECTION_METADATA_CHANGE event, which was recently introduced in ScyllaDB core. This event is emitted when the system.connection_metadata table is updated, allowing the driver to be notified of connection metadata changes.
Key changes:
- Added
CONNECTION_METADATA_CHANGEto the list of known event types in the protocol handler - Implemented the
recv_connection_metadata_changemethod to parse the event data (change type, connection IDs, and host IDs) - Added integration test to verify event reception and parsing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cassandra/protocol.py | Added CONNECTION_METADATA_CHANGE to known event types and implemented parser method for the new event |
| tests/integration/standard/test_control_connection.py | Added integration test that verifies the driver can register for and receive CONNECTION_METADATA_CHANGE events |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
dkropachev
force-pushed
the
dk/add-support-of-connection-metadata-event
branch
from
5ae7d00 to
aad2187
Compare
It turns out that scylla can get new features in the minor version. So, let's ease requirement to ent_scylla_versio and allow any version there.
This event was introduced into the core recently, it is sent whenever `system.conneciton_metadata` table is updated.
dkropachev
force-pushed
the
dk/add-support-of-connection-metadata-event
branch
from
aad2187 to
54535a9
Compare
andrzej-jackowski-scylladb
approved these changes
Nov 25, 2025
andrzej-jackowski-scylladb
left a comment
andrzej-jackowski-scylladb
left a comment
There was a problem hiding this comment.
Looks as expected from the perspective of core
sylwiaszunejko
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This event was introduced into the core recently, it is sent whenever
system.conneciton_metadatatable is updated.There is one more change to it, this PR ease requirements to
ent_scylla_versioninxfail_scylla_version_lt.Initially assumption was that new features are getting only into major releases, but it turned out that it is wrong assumption.
Now you can provide any
ent_scylla_versionintoxfail_scylla_version_ltProbably we need to consider to switch to version predicate instead, to make it more suitable for weird cases when feature gets into
2025.3.3, but not present in2025.4.1.Fixes: #602
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.