Benchmarking report #182
Merged
Benchmarking report #182
+14,217
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move benchmark_compare.sh from project root to tools/ - Update script to change to project root (parent of tools/) before execution - Update usage comment to reflect new location
…n build directory - Add --model flag to optionally specify model path - Add --help flag for usage information - Update build directory cleanup to preserve tracked files (like .gitignore) - Update usage comment to reflect new flag
Run format.sh and fail if any changes are detected
Owner
Author
|
It worked! 😂 |
Use install-llvm-action to install clang-format version 19, ensuring consistent formatting between local (19.1.1) and CI environments.
sdatkinson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds two things to help with PRs:
1. A step in build.yml that runs the formatter. If any changes are detected, the run fails.clang version needs to be decided.2. A benchmarking script. If making changes to existing models, this allows you to quickly compare the speed of a model between your branch and
main. Handy for easily finding performance regressions.