-
Notifications
You must be signed in to change notification settings - Fork 101
[FEATURE] Support multi-input, multi-output models #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdatkinson
wants to merge
19
commits into
main
Choose a base branch
from
148-mimo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored DSP class to eliminate channel-specific input/output level methods, consolidating them into single methods for input and output levels. - Updated related methods and tests to reflect the new simplified interface, ensuring backward compatibility. - Adjusted buffer management in the Buffer class to accommodate the changes in DSP level handling, ensuring all channels use consistent buffer sizes.
- Updated the script to remove all contents from the build directory instead of only untracked files, streamlining the cleanup process before running benchmarks.
This reverts commit 5845787.
…anup" This reverts commit bd4e5a5.
- Included multiple LSTM test cases to validate various functionalities, including basic operations, handling of different buffer sizes, and state evolution. - Ensured comprehensive coverage for LSTM layers by adding tests for multichannel inputs and large hidden sizes.
…onstants - Updated multiple ConvNet test functions to replace hardcoded input and output channel values with defined constants for better readability and maintainability. - Ensured consistency across tests by using the same channel definitions in all relevant instances.
…annels - Implemented a new test case to verify that the process method does not allocate or free memory when handling 3 input channels and 2 output channels. - The test includes setup for weights and input/output buffers, ensuring the output is valid across various buffer sizes. - This enhances the coverage of WaveNet functionality in real-time processing scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #148