-
Notifications
You must be signed in to change notification settings - Fork 314
feat: Add fuzzy search and tag filtering #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Add fuzzy search and tag filtering #539
Conversation
This commit introduces a search bar and tag filtering functionality to the website. - Adds a search bar that allows users to search for conferences. - Implements fuzzy search using Fuse.js to provide a more forgiving search experience. - Updates the tag filtering to use OR logic, allowing users to select multiple tags to broaden the search. - Adds Gemfile and Gemfile.lock to document the dependencies needed for local development.
|
@NIDNASSER-Abdelmajid if your time allows could you please:
Thank you |
index.html
Outdated
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.29.1/moment.min.js" integrity="sha512-qTXRIMyZIFb8iQcfjXWCO8+M5Tbc38Qi5WzdPOYZHIlZpzBHG3L3by84BBBOiRGiEb7KKtAOAs5qYdUiZiQNNQ==" crossorigin="anonymous" referrerpolicy="no-referrer"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment-timezone/0.5.34/moment-timezone-with-data-10-year-range.min.js" integrity="sha512-d11VXfxQMn+sZuIgzHITdIuInr4cVRGV/uLiSI643WH/J+p4gPFYSHXRMR2v+w4Rn2TSyzJjsZjc0M7+Qd+UXw==" crossorigin="anonymous" referrerpolicy="no-referrer"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/store.js/2.0.12/store.legacy.min.js" integrity="sha512-3yZTInL4yLU1ajnca35KTk6YE4RPHJU2y+jbhHAykE9OzMHpc2BIJghNsbkBNacIJWLLUmUkLEGPDDWrFY2zzw==" crossorigin="anonymous" referrerpolicy="no-referrer"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/fuse.js@6.6.2"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will need the integrity="" etc attributes so that it doesn't complain about "inclusion of the functionality from the untrusted source".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi smokhov,
Can you check if it's good now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NIDNASSER-Abdelmajid -- you seem to have simplified the PR by removing the Ruby/Gem stuff altogether. Personally, I think the "Search Functionality" section isn't needed either then. But I will let @clementfung to decide. The PR is otherwise useful. Thank you.
Closes #360
This commit introduces a search bar and tag filtering functionality to the website.